MIgrate some random files away from the torch:: namespace #5836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: A couple tests and helpers that my previous passes didn't catch. After this, the only remaining `//executorch/...` code under the `torch::` namespace is under `backends/...` and `kernels/...` (and in some other places that define kernels). Differential Revision: D63797660
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5836
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 570b745 with merge base 1abecce ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D63797660 |
cccclai
approved these changes
Oct 3, 2024
|
This pull request has been merged in 3a25651. |
|
@pytorchbot cherry-pick --onto release/0.4 -c fixnewfeature |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 4, 2024
Summary: Pull Request resolved: #5836 A couple tests and helpers that my previous passes didn't catch. After this, the only remaining `//executorch/...` code under the `torch::` namespace is under `backends/...` and `kernels/...` (and in some other places that define kernels). Reviewed By: cccclai Differential Revision: D63797660 fbshipit-source-id: f4075d670c6b7f083c8c3ab1e9c465da32e8b3ac (cherry picked from commit 3a25651)
Cherry picking #5836The cherry pick PR is at #5866 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
dvorjackz
pushed a commit
that referenced
this pull request
Oct 4, 2024
MIgrate some random files away from the torch:: namespace (#5836) Summary: Pull Request resolved: #5836 A couple tests and helpers that my previous passes didn't catch. After this, the only remaining `//executorch/...` code under the `torch::` namespace is under `backends/...` and `kernels/...` (and in some other places that define kernels). Reviewed By: cccclai Differential Revision: D63797660 fbshipit-source-id: f4075d670c6b7f083c8c3ab1e9c465da32e8b3ac (cherry picked from commit 3a25651) Co-authored-by: Dave Bort <dbort@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
A couple tests and helpers that my previous passes didn't catch.
After this, the only remaining
//executorch/...code under thetorch::namespace is underbackends/...andkernels/...(and in some other places that define kernels).Differential Revision: D63797660