[ExecuTorch] Unbreak optimized sub in the case where one input is a scalar and both are Half #5940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe is mixed or both are Half (#5894) Summary: Pull Request resolved: #5894 I misplaced a return. Caught this during development in div, but not sub. ghstack-source-id: 246398371 exported-using-ghexport Reviewed By: kirklandsign Differential Revision: D63919553 fbshipit-source-id: 84e27efc400711ae0253e48a4dbdb4b419140925 (cherry picked from commit 1052e3b)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5940
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 980418e with merge base eecf74f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
dvorjackz
reviewed
Oct 9, 2024
I can tell you that the consequences of not picking it are that optimized op_sub will certainly be incorrect. I suppose the risk from picking it is that optimized op_sub might be incorrect in a different way. |
dvorjackz
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
I misplaced a return. Caught this during development in div, but not sub.
Differential Revision: D63919553