Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move benchmark apps to extension/benchmark dir #5971

Closed
wants to merge 1 commit into from
Closed

Move benchmark apps to extension/benchmark dir #5971

wants to merge 1 commit into from

Conversation

pytorchbot
Copy link
Collaborator

No description provided.

@pytorchbot
Move benchmark apps to extension/benchmark dir (#5951)
91d6452 
Summary: Pull Request resolved: #5951

Reviewed By: huydhn

Differential Revision: D64012575

Pulled By: guangy10

fbshipit-source-id: 27bb25586af2aafb8df6c0623d502482b4fa238b
(cherry picked from commit ac2ae07)
This was referenced Oct 8, 2024
Open
Closed
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 8, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/5971

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 91d6452 with merge base eecf74f (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2024
@pytorchbot pytorchbot had a problem deploying to upload-benchmark-results October 8, 2024 03:47 — with GitHub Actions Failure
dvorjackz
dvorjackz reviewed Oct 8, 2024
View reviewed changes
Copy link
Contributor

@dvorjackz dvorjackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this only CI related? From an initial glance seems too risky to CP this late / isn't necessary to include in the release

@dvorjackz dvorjackz closed this Oct 11, 2024
@guangy10
Copy link
Contributor

Is this only CI related? From an initial glance seems too risky to CP this late / isn't necessary to include in the release

Yeah, it's mostly CI related, little real code change to make the CI happy. We have CI build the new apps so I think it's low risk. To double check if it works as expected on the release branch, here are the workflow explicitly build and run with the apps from the new location:

And the PR that updated to doc (#5999) has been cherry-picked and merged. If we don't want to cherry-pick this one, we may have to revert it.

@dvorjackz
Copy link
Contributor

A bit late to CP this now since we are past freeze technically, will can include in next patch

@dvorjackz dvorjackz mentioned this pull request Oct 11, 2024
Merged
@guangy10 guangy10 had a problem deploying to upload-benchmark-results October 11, 2024 19:30 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvorjackz dvorjackz dvorjackz left review comments

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pytorchbot @guangy10 @dvorjackz @facebook-github-bot