[ExecuTorch][xnnpack] Pass QP8 flag only for Kleidi QB4W #6220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6220
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
digantdesai
force-pushed
the
isqp8
branch
3 times, most recently
from
c190876
to
b384ff7
Compare
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kimishpatel
approved these changes
Oct 16, 2024
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
For testing, enable Kleidi using the following changes and run the llama
models on Android with 8da4w and 8da8w linears.
```
-DEXECUTORCH_BUILD_XNNPACK=ON \
+ -DEXECUTORCH_XNNPACK_ENABLE_KLEIDI=ON \
``
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@digantdesai merged this pull request in 065d480. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.