Add a null check for tracer in the Module::load_method
#6298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/6298
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e8c8ce9 with merge base 3b8b28b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64481537 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Summary: When testing the [LLM Manual](https://pytorch.org/executorch/0.4/llm/getting-started.html#profiling-and-debugging), I found etdump is not generated :(. It seems to be a bug introduced in D62520386 when a `tracer` parameter was added to `Module::load_method`. It overrides the `event_tracer_.get()`, resulting `tracer` being null `program_->load_method` is called and thus etdump is not generated. This diff just adds a check: it `tracer` is not null, use it; otherwise use the tracer get from class member event_tracer_. Differential Revision: D64481537
dbort
approved these changes
Oct 16, 2024
tarun292
approved these changes
Oct 16, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Summary: When testing the [LLM Manual](https://pytorch.org/executorch/0.4/llm/getting-started.html#profiling-and-debugging), I found etdump is not generated :(. It seems to be a bug introduced in D62520386 when a `tracer` parameter was added to `Module::load_method`. It overrides the `event_tracer_.get()`, resulting `tracer` being null and passed to `program_->load_method`, thus etdump is not generated. This diff just adds a check: it `tracer` is not null, use it; otherwise use the tracer get from class member event_tracer_. Reviewed By: tarun292, Gasoonjia, dbort Differential Revision: D64481537
facebook-github-bot
force-pushed
the
export-D64481537
branch
from
74d3236
to
1677d98
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64481537 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
Summary: When testing the [LLM Manual](https://pytorch.org/executorch/0.4/llm/getting-started.html#profiling-and-debugging), I found etdump is not generated :(. It seems to be a bug introduced in D62520386 when a `tracer` parameter was added to `Module::load_method`. It overrides the `event_tracer_.get()`, resulting `tracer` being null and passed to `program_->load_method`, thus etdump is not generated. This diff just adds a check: it `tracer` is not null, use it; otherwise use the tracer get from class member event_tracer_. Reviewed By: tarun292, Gasoonjia, dbort Differential Revision: D64481537
facebook-github-bot
force-pushed
the
export-D64481537
branch
from
1677d98
to
f23d2b7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64481537 |
Summary: When testing the [LLM Manual](https://pytorch.org/executorch/0.4/llm/getting-started.html#profiling-and-debugging), I found etdump is not generated :(. It seems to be a bug introduced in D62520386 when a `tracer` parameter was added to `Module::load_method`. It overrides the `event_tracer_.get()`, resulting `tracer` being null and passed to `program_->load_method`, thus etdump is not generated. This diff just adds a check: it `tracer` is not null, use it; otherwise use the tracer get from class member event_tracer_. Reviewed By: tarun292, Gasoonjia, dbort Differential Revision: D64481537
facebook-github-bot
force-pushed
the
export-D64481537
branch
from
f23d2b7
to
e8c8ce9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64481537 |
|
This pull request has been merged in ad0e5e8. |
|
@pytorchbot cherry-pick --onto release/0.4 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Oct 17, 2024
#6298) Summary: Pull Request resolved: #6298 When testing the [LLM Manual](https://pytorch.org/executorch/0.4/llm/getting-started.html#profiling-and-debugging), I found etdump is not generated :(. It seems to be a bug introduced in D62520386 when a `tracer` parameter was added to `Module::load_method`. It overrides the `event_tracer_.get()`, resulting `tracer` being null and passed to `program_->load_method`, thus etdump is not generated. This diff just adds a check: it `tracer` is not null, use it; otherwise use the tracer get from class member event_tracer_. Reviewed By: tarun292, Gasoonjia, dbort Differential Revision: D64481537 fbshipit-source-id: 86cecbaea2b7293be28d60f4147deb31535fa6ea (cherry picked from commit ad0e5e8)
Cherry picking #6298The cherry pick PR is at #6319 The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
dvorjackz
pushed a commit
that referenced
this pull request
Oct 17, 2024
Add a null check for `event_tracer` param in the `Module::load_method` (#6298) Summary: Pull Request resolved: #6298 When testing the [LLM Manual](https://pytorch.org/executorch/0.4/llm/getting-started.html#profiling-and-debugging), I found etdump is not generated :(. It seems to be a bug introduced in D62520386 when a `tracer` parameter was added to `Module::load_method`. It overrides the `event_tracer_.get()`, resulting `tracer` being null and passed to `program_->load_method`, thus etdump is not generated. This diff just adds a check: it `tracer` is not null, use it; otherwise use the tracer get from class member event_tracer_. Reviewed By: tarun292, Gasoonjia, dbort Differential Revision: D64481537 fbshipit-source-id: 86cecbaea2b7293be28d60f4147deb31535fa6ea (cherry picked from commit ad0e5e8) Co-authored-by: Olivia Liu <olivialpx@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When testing the LLM Manual, I found etdump is not generated :(. It seems to be a bug introduced in D62520386 when a
tracerparameter was added toModule::load_method. It overrides theevent_tracer_.get(), resultingtracerbeing nullprogram_->load_methodis called and thus etdump is not generated.This diff just adds a check: it
traceris not null, use it; otherwise use the tracer get from class member event_tracer_.Differential Revision: D64481537