You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I recently exposed LRScheduler to be public (instead of _LRScheduler) in pytorch/pytorch#88503. I see several instance checks in this current repo that use _LRScheduler, and I believe these should be updated to be LRScheduler.
Why?
This would be a good step in the right direction. Also, downstream users who subscribe to new LRScheduler (and not _LRScheduler) now will run into issues.
Alternatives
Maybe the best thing to do for forward and backward compatibility is to accept LRScheduler whenever there is _LRScheduler too.
The text was updated successfully, but these errors were encountered:
Update code to be compatible with LRScheduler too
I recently exposed LRScheduler to be public (instead of _LRScheduler) in pytorch/pytorch#88503. I see several instance checks in this current repo that use _LRScheduler, and I believe these should be updated to be LRScheduler.
Why?
This would be a good step in the right direction. Also, downstream users who subscribe to new LRScheduler (and not _LRScheduler) now will run into issues.
Alternatives
Maybe the best thing to do for forward and backward compatibility is to accept LRScheduler whenever there is _LRScheduler too.
The text was updated successfully, but these errors were encountered: