Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated arguments #1051

Merged
merged 14 commits into from
May 20, 2020
Merged

Remove deprecated arguments #1051

merged 14 commits into from
May 20, 2020

Conversation

erip
Copy link
Contributor

@erip erip commented May 18, 2020

Fixes #1038

Description: This aims to clean up some of the deprecated APIs that are set to be removed in 0.4.0.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@erip erip requested a review from vfdev-5 May 18, 2020 01:15
ignite/engine/engine.py Outdated Show resolved Hide resolved
ignite/handlers/checkpoint.py Outdated Show resolved Hide resolved
ignite/handlers/checkpoint.py Show resolved Hide resolved
ignite/handlers/checkpoint.py Show resolved Hide resolved
@erip erip requested a review from vfdev-5 May 20, 2020 00:38
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erip !

@vfdev-5 vfdev-5 merged commit 3afba87 into pytorch:master May 20, 2020
@erip erip deleted the feature/remove-deprecated-apis branch May 20, 2020 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated args for v0.4.0
2 participants