Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #813 #1072

Merged
merged 7 commits into from
May 29, 2020
Merged

Fix #813 #1072

merged 7 commits into from
May 29, 2020

Conversation

sdesrozis
Copy link
Contributor

@sdesrozis sdesrozis commented May 26, 2020 •
edited
Loading

Fixes #813 (partially

Description:

Some _LRScheduler (CosineAnnealingWarmRestarts and MultiplicativeLR) are not compatible with LRScheduler.simulate_values(). The replication of the schedulers was making assumptions about how is implemented scheduler.

Replication is replaced by saves similar to lr_finder.

Today CosineAnnealingWarmRestarts still failed because it needs explicit call to step() while ParamScheduler uses get_lr().

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@sdesrozis sdesrozis requested a review from vfdev-5 May 29, 2020 14:35
vfdev-5
vfdev-5 approved these changes May 29, 2020
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@sdesrozis sdesrozis merged commit b6af776 into pytorch:master May 29, 2020
@sdesrozis sdesrozis deleted the issue_813 branch May 29, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CosineAnnealingWarmRestarts is not compatible with LRScheduler.simulate_values()
2 participants
@sdesrozis @vfdev-5