Keep nvcc for MSDeepSpeed Docker image #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trsvchn thank you. What is the size of the image keeping g++ ? |
trsvchn
force-pushed
the
deepspeed-image-fix
branch
from
a31fe95
to
d2bdf83
Compare
w/o g++ pytorchignite/msdp-apex latest 14.4GB
w g++ pytorchignite/msdp-apex latest 14.6GB |
vfdev-5
reviewed
Feb 27, 2021
|
I also rebuilt it and have taking into account that pytorch devel image is |
vfdev-5
added a commit
that referenced
this pull request
Mar 3, 2021
* Keep nvcc for MSDeepSpeed Docker image * Update Dockerfile.msdp-apex * Fix broken links for docker images Co-authored-by: vfdev <vfdev.5@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1710
Description:
Prevents
nvccfrom being removed by excludingg++removing step from Docker fileCheck list: