Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): navigation with left/right arrow keys #1726

Merged
merged 1 commit into from
Mar 2, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Mar 2, 2021

Fixes #{issue number}

Description:

https://deploy-preview-1726--pytorch-ignite-preview.netlify.app

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 2, 2021

@ydcjeff thanks for the PR ! Do you like how it works ?

I tried this feature and find it a bit strange ...

  • if you do only left left ... it changes between quick-start and main page alternatively

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Mar 2, 2021

I like tho tbh.
Yes, I tried left and left, it goes between quick-start and index page
Yes, it happens to this site also : https://pydata-sphinx-theme.readthedocs.io/en/latest/index.html

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Mar 2, 2021

Thanks for the reference on pydata and seems like pandas also uses that. Why not!

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making our docs modern :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants