Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes part of #1725: [flake8] Remove unused imports in engine and contrib.engines #1734

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Fixes part of #1725: [flake8] Remove unused imports in engine and contrib.engines #1734

merged 2 commits into from
Mar 3, 2021

Conversation

OBITORASU
Copy link
Contributor

@OBITORASU OBITORASU commented Mar 3, 2021 •
edited
Loading

Fixes part of #1725

Description:
Fixed all the unused import warnings present in ignite.engine and ignite.contrib.engines which were generated by flake8 when F401 was removed from setup.cfg.

I have ignored the __init__.py file for ignite.contrib.engines

Files Changed:

  • ignite.engine
  • ignite.contrib.engines

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@OBITORASU OBITORASU changed the title Fixes part of #1725: [flake8] Remove unused imports in engine Fixes part of #1725: [flake8] Remove unused imports in engine and contrib.engines Mar 3, 2021
vfdev-5
vfdev-5 approved these changes Mar 3, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OBITORASU , looks good!

@vfdev-5 vfdev-5 merged commit 384d686 into pytorch:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OBITORASU @vfdev-5