Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8] remove unused imports in distributed #1747

Merged
merged 1 commit into from
Mar 6, 2021
Merged

[flake8] remove unused imports in distributed #1747

merged 1 commit into from
Mar 6, 2021

Conversation

Moh-Yakoub
Copy link
Contributor

@Moh-Yakoub Moh-Yakoub commented Mar 6, 2021 •
edited
Loading

Addresses part of #1725

Description:

  1. removed F401 from setup.cfg
  2. run flake8 on ignite/distributed
  3. Remove unused imports
  4. Revert setup.cfg

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: distributed Distributed module label Mar 6, 2021
sdesrozis
sdesrozis approved these changes Mar 6, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Moh-Yakoub thank you, LGTM

@sdesrozis sdesrozis merged commit a4a9f47 into pytorch:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis sdesrozis approved these changes

Assignees
No one assigned
Labels
module: distributed Distributed module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Moh-Yakoub @sdesrozis