Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rouge last details #1804

Merged
merged 4 commits into from
Mar 16, 2021
Merged

Rouge last details #1804

merged 4 commits into from
Mar 16, 2021

Conversation

gucifer
Copy link
Contributor

@gucifer gucifer commented Mar 16, 2021

Added a new test for multireference value check.
Added RougeN and RougeL to docs.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added docs module: metrics Metrics module labels Mar 16, 2021
sdesrozis
sdesrozis reviewed Mar 16, 2021
View reviewed changes
.vscode/settings.json Outdated Show resolved Hide resolved
sdesrozis
sdesrozis reviewed Mar 16, 2021
View reviewed changes
ignite/metrics/rouge.py Outdated Show resolved Hide resolved
vfdev-5
vfdev-5 approved these changes Mar 16, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vfdev-5 vfdev-5 merged commit b973213 into pytorch:master Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis sdesrozis left review comments

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
docs module: metrics Metrics module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gucifer @vfdev-5 @sdesrozis