Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended MetricsLambda to update its underlying metrics #2091

Merged
merged 5 commits into from
Jul 3, 2021
Merged

Extended MetricsLambda to update its underlying metrics #2091

merged 5 commits into from
Jul 3, 2021

Conversation

KickItLikeShika
Copy link
Contributor

Fixes #1921

Implemented the update method to make metrics lambda able to update its underlying methods, and I separated the attach from reset/update/compute API, then implemented the necessary tests.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: metrics Metrics module label Jun 30, 2021
vfdev-5
vfdev-5 reviewed Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the PR @KickItLikeShika

ignite/metrics/metrics_lambda.py Outdated Show resolved Hide resolved
vfdev-5
vfdev-5 approved these changes Jul 2, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot @KickItLikeShika !

@vfdev-5 vfdev-5 enabled auto-merge (squash) July 2, 2021 20:24
@vfdev-5 vfdev-5 merged commit 0b2072d into pytorch:master Jul 3, 2021
@KickItLikeShika KickItLikeShika deleted the extend-metricslambda branch July 3, 2021 08:44
@trsvchn trsvchn mentioned this pull request Aug 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: metrics Metrics module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make MetricsLambda update it's underlying metrics
2 participants
@KickItLikeShika @vfdev-5