Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fid import scipy #2103

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Fix fid import scipy #2103

merged 2 commits into from
Jul 12, 2021

Conversation

sdesrozis
Copy link
Contributor

Description:

Fix import error with scipy

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: metrics Metrics module label Jul 10, 2021
vfdev-5
vfdev-5 reviewed Jul 10, 2021
View reviewed changes
ignite/metrics/gan/fid.py Outdated Show resolved Hide resolved
vfdev-5
vfdev-5 reviewed Jul 10, 2021
View reviewed changes
ignite/metrics/gan/fid.py Outdated Show resolved Hide resolved
@sdesrozis
Copy link
Contributor Author

sdesrozis commented Jul 10, 2021 •
edited
Loading

Surprising. I will fix this. Yet I had merged my fork with the master.

vfdev-5
vfdev-5 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdesrozis

@vfdev-5 vfdev-5 merged commit 289d99d into pytorch:master Jul 12, 2021
@vfdev-5 vfdev-5 deleted the fix_fid branch July 12, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: metrics Metrics module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdesrozis @vfdev-5