auto_optim enhancement #2169
Merged
auto_optim enhancement #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Chandan-h-509 Thank you ! It would be nice to have a test of this new feature. |
|
@sdesrozis I have added the test case. |
sdesrozis
reviewed
Aug 22, 2021
|
@Chandan-h-509 a minor comment to address and a format error to fix. See https://github.com/pytorch/ignite/pull/2169/checks?check_run_id=3389112372 Otherwise, it looks good 👍🏻 |
|
@sdesrozis I have made the final changes. |
sdesrozis
approved these changes
Aug 22, 2021
vfdev-5
reviewed
Aug 22, 2021
|
cc @sandylaker for visibility |
|
@vfdev-5 I have made the new change as requested. |
vfdev-5
reviewed
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2168
Description: Add kwargs to the auto_optim argument and pass it to DistributedOptimizer .
Check list: