-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include micro averaging - Bleu Score #2179
Conversation
@sdesrozis could you have a look, if the structure is correct so that I can change the tests also. |
@Ishan-Kumar2 I did a plenty of comments, sorry for that. I think we could improve a bit what you did. The main point is the use of local/class variables. |
Another remark. Micro and batch are two things which could be tackled separately. If you loop over the batch example, you can have a batch macro version (which is not done). Micro average is the "correct" (I mean most common) bleu metric. This is naturally compatible with batch. I suggest that we keep the actual |
@sdesrozis thank you for the helpful reviews, I will first make another PR with just the addition of batch (and corresponding tests) then continue here for micro. |
Do as you prefer. I can help on the development of this PR because it is very clear to me 😉 Let me know. |
@sdesrozis , I have merged the other PRs contents and made the changes you suggested. If the micro avg calculation method is correct, I can add tests for the same. |
I converted to draft since it misses the tests and maybe some discussion is still needed. |
@Ishan-Kumar2 Thanks a lot for the work, although a few last comments to address. Moreover, the tests seems ko. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ishan-Kumar2 Thank you very much ! LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit comment, otherwise LGTM as well
Fixes #2178
Description:
Have included method to pass batch of inputs to
update
and allow macro averaging also.[WIP] The tests need to be added
Check list: