Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NLP flavored docker images by specifying torchtext version, update versions of dependencies, refactor ci #2270

Merged
merged 12 commits into from
Oct 16, 2021

Conversation

trsvchn
Copy link
Collaborator

@trsvchn trsvchn commented Oct 15, 2021

Fixes Falling docker builds on release And Addresses #1879

Description:

torchtext of version 0.10.1 forces to install torch=1.9.1. This breaks nlp flavored images, which a re based on torch=1.9.0

This PR:

  1. Fixes builds by harcoding the right version of torchtext (<0.10.1)
  2. Updates horovod version to 0.23.0
  3. Updates deepspeed to 0.5.4
  4. Refactors versions extraction for docker builds, see ci: up pytorch to 1.8.1 #1878 (comment)

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

.circleci/config.yml Outdated Show resolved Hide resolved
@trsvchn trsvchn changed the title Fix NLP flavored docker images by specifying torchtext version Fix NLP flavored docker images by specifying torchtext version, update versions of dependencies, refactor ci Oct 15, 2021
@trsvchn trsvchn requested a review from vfdev-5 October 15, 2021 21:55
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trsvchn !

@vfdev-5 vfdev-5 merged commit c399ee9 into pytorch:master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants