Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctest for nlp metrics (BLEU, Rouge, RougeN, RougeL) #2317

Merged
merged 2 commits into from
Nov 12, 2021

Conversation

sdesrozis
Copy link
Contributor

Addresses #2265

Description: Added doctests for BLEU, Rouge, RougeN, RougeL

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: metrics Metrics module label Nov 9, 2021
@sdesrozis
Copy link
Contributor Author

@ydcjeff Hey, could you review please ? Still cant find you in the review menu :'

Copy link
Contributor

@ydcjeff ydcjeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @sdesrozis

@sdesrozis sdesrozis merged commit 98d476b into pytorch:master Nov 12, 2021
@sdesrozis sdesrozis mentioned this pull request Nov 12, 2021
51 tasks
@sdesrozis sdesrozis deleted the doctest_nlp branch November 12, 2021 13:48
fco-dv pushed a commit to fco-dv/ignite that referenced this pull request Nov 23, 2021
Co-authored-by: Desroziers <sylvain.desroziers@michelin.com>
Ishan-Kumar2 pushed a commit to Ishan-Kumar2/ignite that referenced this pull request Dec 26, 2021
Co-authored-by: Desroziers <sylvain.desroziers@michelin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: metrics Metrics module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants