-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed ClearMLLogger to retrieve current task before trying to create a new one. #2344
Conversation
@H4dr1en thanks for the PR ! Do you think we can write a distributed test for checking that everything is working ? |
@vfdev-5 This might be very tricky to test: we want to make sure that the communication between the subprocesses and the main process works well, so that clearml can log successfully in the clearml-server. I have now idea how to test that :D Especially since there is no error to catch, this happens silently in the background |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@H4dr1en thanks a lot for the PR !
For the tests I agree that this could be a bit tricky to write and there is no error to catch.
Let's merge this like that and if possible to add a test we can do that later in a follow-up PR.
I still would like to hear from ClearML team.
@bmartinn could you please review as well. Thanks !
EDIT: There is a lint to fix and TPU tests are unrelated
* fix pytorch#2343 * update docstring * add comment * fix docstrings * remove trailing whitespace Co-authored-by: vfdev <vfdev.5@gmail.com>
Fixes #2343
Description: ClearMLLogger tries to retrieve current task before trying to create a new one.
Check list: