Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chenglu/black #2378

Merged
merged 4 commits into from
Dec 21, 2021
Merged

Chenglu/black #2378

merged 4 commits into from
Dec 21, 2021

Conversation

louis-she
Copy link
Contributor

@louis-she louis-she commented Dec 21, 2021 •
edited by vfdev-5
Loading

Fixes #2366

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

vfdev-5 and others added 3 commits December 18, 2021 17:17
@vfdev-5
Updated black to 21.12b0 and fixed codebase for others folders (pytor…
ee762fb 
…ch#2367)

* Updated black to 21.12b0 and fixed codebase for others folders

* Updated black
@louis-she
formatting fixed (pytorch#2372)
1bc72ca 
* fix: remove tailing commas that would mislead black formating

* autopep8 fix

* fix: left out tailing comma

* chg: change black version

* fix: test_deprecated assert failed with additional newline

* fix: typo

* fix: fix func_no_reasons test assert failed

Co-authored-by: louis-she <louis-she@users.noreply.github.com>
@vfdev-5
Merge branch 'master' into black-21.12b0
8299271
@github-actions github-actions bot added ci CI docker examples Examples module: contrib Contrib module module: distributed Distributed module module: engine Engine module module: handlers Core Handlers module module: metrics Metrics module module: utils Utils module labels Dec 21, 2021
vfdev-5
vfdev-5 approved these changes Dec 21, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @louis-she !

@vfdev-5 vfdev-5 merged commit 5737b06 into pytorch:master Dec 21, 2021
@louis-she louis-she deleted the chenglu/black branch December 21, 2021 09:02
@vfdev-5 vfdev-5 mentioned this pull request Dec 21, 2021
Closed
3 tasks
Ishan-Kumar2 pushed a commit to Ishan-Kumar2/ignite that referenced this pull request Dec 26, 2021
@louis-she @vfdev-5 @Ishan-Kumar2
Chenglu/black (pytorch#2378)
5dcee96 
* Updated black to 21.12b0 and fixed codebase for others folders (pytorch#2367)

* Updated black to 21.12b0 and fixed codebase for others folders

* Updated black

* formatting fixed (pytorch#2372)

* fix: remove tailing commas that would mislead black formating

* autopep8 fix

* fix: left out tailing comma

* chg: change black version

* fix: test_deprecated assert failed with additional newline

* fix: typo

* fix: fix func_no_reasons test assert failed

Co-authored-by: louis-she <louis-she@users.noreply.github.com>

Co-authored-by: vfdev <vfdev.5@gmail.com>
Co-authored-by: louis-she <louis-she@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
ci CI docker examples Examples module: contrib Contrib module module: distributed Distributed module module: engine Engine module module: handlers Core Handlers module module: metrics Metrics module module: utils Utils module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update black to 21.12b0
2 participants
@louis-she @vfdev-5