Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytorch.org/ignite site and reference pytorch-ignite.ai #2325 #2431

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

Moh-Yakoub
Copy link
Contributor

@Moh-Yakoub Moh-Yakoub commented Jan 18, 2022

Related to #2325

Description: I've updated some of the links as specified in the associated tasks and updated docs accordingly

To test it

1. cd docs
2. make html
3. cd build/
4. python -m http.server 8989

Checked the links and they referencing the updated links instead of the old html.

I didn't change the main URL (https://pytorch.org/ignite') to the new URL because it will break the pages not available for the new URL (for instance: examples), will change the base to the new URL once all of the URLs are available on the (pytorch-ignite.ai/) URL

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the docs label Jan 18, 2022
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Moh-Yakoub thanks for the PR ! It looks good and we can merge it.
However, in order to finalize the migration we need to make a bit more updates to the API ref website. I'll update the issue description.
Basically, we need to have consistent reference to https://pytorch-ignite.ai
The index page have to minimally expose a reference https://pytorch-ignite.ai ...

@vfdev-5 vfdev-5 merged commit 336b0c3 into pytorch:master Jan 18, 2022
@vfdev-5 vfdev-5 mentioned this pull request Jan 18, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants