Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary code in BaseOutputHandler #2439

Merged
merged 1 commit into from
Jan 22, 2022
Merged

Remove unnecessary code in BaseOutputHandler #2439

merged 1 commit into from
Jan 22, 2022

Conversation

sadra-barikbin
Copy link
Collaborator

@sadra-barikbin sadra-barikbin commented Jan 22, 2022 •
edited
Loading

Fixes #2438

Description:
Dictionary comprehension was unnecessary.
Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: contrib Contrib module label Jan 22, 2022
vfdev-5
vfdev-5 approved these changes Jan 22, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @sadra-barikbin

@vfdev-5 vfdev-5 merged commit e2d9047 into pytorch:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: contrib Contrib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Seemingly unnecessary dictionary comprehension in contrib's BaseOutputHandler
2 participants
@sadra-barikbin @vfdev-5