Feature step param scheduler issue 2488 #2489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix bug in min_lr check
sadra-barikbin
force-pushed
the
feature-step-param-scheduler-issue-2488
branch
5 times, most recently
from
f1ca6ed
to
936df89
Compare
|
@sadra-barikbin I would suggest to pause on this PR as we haven't decided to move forward with this feature request. Let's work on something else. For example: #2328 (this one is not assigned to anyone) |
|
@vfdev-5 |
@sadra-barikbin yes, it is not finished and probably wont be finished. You can either start from scratch or take something useful from that PR. |
sadra-barikbin
force-pushed
the
feature-step-param-scheduler-issue-2488
branch
from
936df89
to
c5c5822
Compare
|
@sadra-barikbin can we close this PR ? |
|
Yes, I did. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2488
Description:
This is the proposed implementation for
StepParamSchedulerfeature.Check list: