-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed ProgressBar init's type annotation to accept None #2541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Davidportlouis , lgtm. Let's see if CI is passing and then we can merge it
@Davidportlouis code formatting checks are not passing: https://github.com/pytorch/ignite/runs/5858540569?check_suite_focus=true#step:11:64 Please reformat the code according to https://github.com/pytorch/ignite/blob/master/CONTRIBUTING.md#formatting-code |
Fixed it |
@Davidportlouis Tests are still failing because of string mismatch. Could you have a look please ? It would be great to run the tests locally before committing. |
Sure i'll check it and run tests locally |
Fixed the string formatting issue, some tests (resume based tests) in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Davidportlouis , LGTM !
Fixes #2540
Description:
None
tobar_format
type annotation in initialization argument ofignite.contrib.handlers.tqdm_logger.ProgressBar
Check list: