Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving various tests with parametrize #2552

Merged
merged 14 commits into from
Apr 19, 2022

Conversation

nmcguire101
Copy link
Contributor

#2522 Adding more improvements to tests

Description:
Improved test tests\ignite\contrib\metrics\test_accuracy.py using pytest parametrize

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Apr 17, 2022

@nmcguire101 thanks for the PR. By the way, for effectively contributing using git, please check https://github.com/firstcontributions/first-contributions
Basically, the idea is to create new branch synced with remote master for every new feature. This would help to avoid keeping previous unrelated commits.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmcguire101 can you please also update test_multiclass_input

tests/ignite/metrics/test_accuracy.py Outdated Show resolved Hide resolved
tests/ignite/metrics/test_accuracy.py Outdated Show resolved Hide resolved
tests/ignite/metrics/test_accuracy.py Outdated Show resolved Hide resolved
tests/ignite/metrics/test_accuracy.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @nmcguire101

@vfdev-5 vfdev-5 merged commit 727150e into pytorch:master Apr 19, 2022
@nmcguire101 nmcguire101 deleted the nmcguire101 branch April 19, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants