-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix an error message of confusion_matrix.IoU #2613
fix an error message of confusion_matrix.IoU #2613
Conversation
@BowmanChow thanks for the PR, I let @sadra-barikbin review it and comment out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @BowmanChow , thanks for the PR. Could you please apply this change to other places of confusion_matrix.py? For example line 396.
8e16e75
to
864db9f
Compare
Hi @sadra-barikbin , I made another change and force-pushed, because I want to keep the commit tree clean. I'm not sure whether force-push is ok. Is it mergable? |
@BowmanChow yes, it is ok to push-force. As it is your first contribution we need to approve to run the CI. By the way, can you please check if there is a confusion matrix test which check for previous message error. If there is one, then it will fail now as you changed the error message. Please fix:
|
@vfdev-5 I'm sorry that I thought my changes were so small and don't need a check. I will have the formatting and test run. |
864db9f
to
31293e1
Compare
Hi @vfdev-5 , I've completed the formatting and test_confusion_matrix.py check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @BowmanChow ! LGTM
CI failures are unrelated. I'll merge your PR once we fixed issues on master and I updated your PR.
Description:
An error message in ignite.metrics.confusion_matrix.IoU is confusing and does not match the condition check, which might lead to misunderstanding. I update the error message to make it match the condition check.
Check list: