Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update geometric_mean_relative_absolute_error, manhattan_distance, maximum_absolute_error in test for generating data with different rank #2664

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Update geometric_mean_relative_absolute_error, manhattan_distance, maximum_absolute_error in test for generating data with different rank #2664

merged 2 commits into from
Aug 23, 2022

Conversation

puhuk
Copy link
Contributor

@puhuk puhuk commented Aug 22, 2022

Description: Update geometric_mean_relative_absolute_error, manhattan_distance, maximum_absolute_error to generate with different rank

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@puhuk
Update geometric_mean_relative_absolute_error, manhattan_distance…
b78869e 
…, `maximum_absolute_error`

Update `geometric_mean_relative_absolute_error`, `manhattan_distance`, `maximum_absolute_error` to generate with different rank
@puhuk puhuk changed the title Update 3 metrics in test for generating data with different rank Update geometric_mean_relative_absolute_error, manhattan_distance, maximum_absolute_error in test for generating data with different rank Aug 23, 2022
vfdev-5
vfdev-5 approved these changes Aug 23, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @puhuk , lgtm !

@vfdev-5 vfdev-5 enabled auto-merge (squash) August 23, 2022 06:42
@vfdev-5 vfdev-5 merged commit 0818fe3 into pytorch:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puhuk @vfdev-5