Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue when removing handlers on filtered events #2690

Merged
merged 6 commits into from
Sep 4, 2022
Merged

Fixed issue when removing handlers on filtered events #2690

merged 6 commits into from
Sep 4, 2022

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Sep 2, 2022

Fixes #2684

Description:

  • Fixed issue when removing handlers on filtered events
  • Updated tests
  • Some code formatting to reduce LOC

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: engine Engine module label Sep 2, 2022
@vfdev-5 vfdev-5 enabled auto-merge (squash) September 4, 2022 15:32
@vfdev-5 vfdev-5 enabled auto-merge (squash) September 4, 2022 15:39
@vfdev-5 vfdev-5 enabled auto-merge (squash) September 4, 2022 16:23
@vfdev-5 vfdev-5 merged commit 5acbaa3 into pytorch:master Sep 4, 2022
@vfdev-5 vfdev-5 deleted the fix-2684-remove-filtered-handler branch September 4, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadra-barikbin sadra-barikbin sadra-barikbin approved these changes

Assignees
No one assigned
Labels
module: engine Engine module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to remove handler attached on filtered event
2 participants
@vfdev-5 @sadra-barikbin