Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: accumulation should not effect value of loss #2737

Merged
merged 3 commits into from
Oct 9, 2022
Merged

FIX: accumulation should not effect value of loss #2737

merged 3 commits into from
Oct 9, 2022

Conversation

louis-she
Copy link
Contributor

@louis-she louis-she commented Oct 9, 2022 •
edited
Loading

Fixes #2707 2707

Description:

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: engine Engine module label Oct 9, 2022
@louis-she
Copy link
Contributor Author

codecov seems to be not going right here. The code just changes some value comparisons.

vfdev-5
vfdev-5 approved these changes Oct 9, 2022
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @louis-she , looks good to me!

@vfdev-5 vfdev-5 enabled auto-merge (squash) October 9, 2022 21:22
@vfdev-5 vfdev-5 merged commit 8d5d7ca into pytorch:master Oct 9, 2022
@louis-she louis-she deleted the louis/fix-scale-of-loss branch October 10, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: engine Engine module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gradient_accumulation_steps influences scale of the loss
2 participants
@louis-she @vfdev-5