-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing CI #2757
Fix failing CI #2757
Conversation
Let's put Neptune fix here and try to fix RL example as well once we understand the root of the issue. |
@@ -187,7 +187,10 @@ def __init__(self, *args: Any, **kwargs: Any) -> None: | |||
|
|||
if kwargs.get("offline_mode", False): | |||
self.mode = "offline" | |||
neptune.init(project_qualified_name="dry-run/project", backend=neptune.OfflineBackend()) | |||
neptune.init( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will take a look at it tomorrow morning :)
@louis-she can you please disable neptune tests such that we could merge this PR. Do you think this version pin is necessary ?
|
the root cause of the 2 errors, one from
The pip install will resolve the conflicts by get the older version of |
Thanks for the explanation @louis-she ! I would suggest to temporarily comment out neptune dependency in requirements-dev.txt and add pytest.skip("Temporarily skip neptune tests", allow_module_level=True) into Once neptune folks updated our code to their latest API version and also fix the issue with EDIT: or keep your solution with downgraded neptune-client version, I like that as well ! |
I fixed the version of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @louis-she !
#2756 (comment)