-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve RunningAverage reset when epoch_bound=False #2950
Merged
vfdev-5
merged 5 commits into
pytorch:master
from
sadra-barikbin:Improve-reset-RunningAverage-at-first-epoch
May 22, 2023
Merged
Improve RunningAverage reset when epoch_bound=False #2950
vfdev-5
merged 5 commits into
pytorch:master
from
sadra-barikbin:Improve-reset-RunningAverage-at-first-epoch
May 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
reviewed
May 21, 2023
vfdev-5
reviewed
May 21, 2023
vfdev-5
reviewed
May 21, 2023
Thanks for the PR @sadra-barikbin ! I left few comments and please update PR's description as it states :
but you add more code, this looks a bit misleading |
…ningAverage-at-first-epoch' into Improve-reset-RunningAverage-at-first-epoch
by the way, let's simplify this code as well: - @trainer.on(Events.STARTED)
- def running_avg_output_init(engine):
- engine.state.running_avg_output = None
+ trainer.state.running_avg_output = None |
vfdev-5
approved these changes
May 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When
epoch_bound=False
, an explicitmetric.reset()
was required beforeanother
engine.run
. This PR getsRunningAverage
to reset itself automatically.Check list: