Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Cycle-GAN notebook #500

Merged
merged 6 commits into from
May 2, 2019
Merged

Added Cycle-GAN notebook #500

merged 6 commits into from
May 2, 2019

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Apr 25, 2019

Description: Added Cycle-GAN training notebook

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5 vfdev-5 changed the title [WIP] Added Cycle-GAN notebook Added Cycle-GAN notebook Apr 26, 2019
@vfdev-5 vfdev-5 marked this pull request as ready for review April 26, 2019 11:33
@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented Apr 28, 2019

ping @anmolsjoshi

@anmolsjoshi
Copy link
Contributor

@vfdev-5 thanks for the PR, currently reviewing. Should have an update by tomorrow.

@vfdev-5
Copy link
Collaborator Author

vfdev-5 commented May 1, 2019

@anmolsjoshi any updates

anmolsjoshi
anmolsjoshi approved these changes May 2, 2019
View reviewed changes
Copy link
Contributor

@anmolsjoshi anmolsjoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 LGTM! I've wanted to learn about GANs, this is a solid example!

@vfdev-5 vfdev-5 merged commit 2a2eb1e into pytorch:master May 2, 2019
@vfdev-5 vfdev-5 deleted the cycle-gan branch May 2, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anmolsjoshi anmolsjoshi anmolsjoshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vfdev-5 @anmolsjoshi