Typing Core Package #716
Merged
Typing Core Package #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing tests are just part of the contrib package (which I didn't even touch). How shall we proceed here? |
vfdev-5
reviewed
Jan 23, 2020
There was a problem hiding this comment.
@justusschock thanks for the PR ! I left some comments to improve it.
|
@justusschock I let you resolve the conflicts and it will be OK to merge |
Co-Authored-By: vfdev <vfdev.5@gmail.com>
vfdev-5
reviewed
Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #651
Description:
This PR will add typings for the whole core package (
ignite.engine,ignite.metrics, `ignite.handlers) but NOT for the contrib part so far.Check list:
cc @vfdev-5