Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#870 : use type Any for event_name in engine #877

Merged
merged 1 commit into from
Apr 4, 2020

Conversation

sdesrozis
Copy link
Contributor

Fixes #870

Description:

Use type Any for event_name in engine. PyCharm really likes it.

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Sylvain !

@vfdev-5 vfdev-5 merged commit d6fdf9d into pytorch:master Apr 4, 2020
@sdesrozis sdesrozis deleted the issue-870 branch April 5, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better typing for Engine
2 participants