Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update common.py #904

Merged
merged 3 commits into from
Apr 8, 2020
Merged

Update common.py #904

merged 3 commits into from
Apr 8, 2020

Commits on Apr 8, 2020

  1. Update common.py 

    I think `_setup_common_training_handlers(...)` is missing its `return trainer` statement at the end of it. I've added it here.

If this is in error, please just reject and close this.
    @willfrey
    willfrey authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    04d5208 View commit details
    Browse the repository at this point in the history

  2. Update common.py 

    Removed `return trainer` or equivalent statements from the public and helper `setup_xxx(...)` functions.
    @willfrey
    willfrey authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    696a5dc View commit details
    Browse the repository at this point in the history

  3. Update common.py

    @vfdev-5
    vfdev-5 authored Apr 8, 2020
    Configuration menu
    Copy the full SHA
    fd403d8 View commit details
    Browse the repository at this point in the history