-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add declarative trainer #924
Conversation
@Minyus Thank you very much for this PR !! I make you my feedback on your proposal quickly :) |
@Minyus thanks a lot for the PR ! I really appreciate your contribution, however it would be great to discuss more about the API. We already stated some general remarks on the API in the related issue #912 In my opinion, class please, let's discuss more about the API in #912. |
@Minyus can we work out this at first, please ? class TimeLimit:
def __init__(self, limit_sec=3600):
self.limit_sec = limit_sec
self.start_time = time.time()
def __call__(self, engine):
elapsed_time = time.time() - self.start_time
if elapsed_time > self.limit_sec:
log.warning("Reached the time limit: {} sec. Stop training".format(self.limit_sec))
engine.terminate() This looks good enough. Maybe, in addition, we can set Idea is to put it directly into |
@vfdev-5 |
@Minyus thanks, but it would be much better to split this PR into several ones. One PR by feature. |
As discussed in Slack, this PR is suspended. Meanwhile, please feel free to send PR (including adding documentation, test, example, etc.) to PipelineX so that I can send a complete PR to Ignite later on. higher API for training MNIST example to use higher API TimeLimit handler Cohen Kappa Score metric Please also feel free to copy any code in PipelineX to use in PyTorch Ignite. |
Thank you again and see you soon !! |
Fixes # 912
Description:
Higher API for training will improve usability of Ignite.
Check list: