Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #993 #994

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fixes #993 #994

merged 1 commit into from
Apr 28, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Apr 28, 2020

Fixes #993

Description:

  • Take into account run's argument before checking if run is done

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5 vfdev-5 requested a review from sdesrozis April 28, 2020 15:15
sdesrozis
sdesrozis approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdesrozis
Copy link
Contributor

CI ko 😔

@vfdev-5
Fixes pytorch#993
36e48ab 
- Take into account run's argument before checking if run is done
@vfdev-5 vfdev-5 merged commit e30b9fc into pytorch:master Apr 28, 2020
@vfdev-5 vfdev-5 deleted the issue-993 branch April 28, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdesrozis sdesrozis sdesrozis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Engine restarts training from scratch unexpected
2 participants
@vfdev-5 @sdesrozis