Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): navigate with left/right arrow keys #1226

Closed
wants to merge 3 commits into from
Closed

feat(docs): navigate with left/right arrow keys #1226

wants to merge 3 commits into from

Conversation

ydcjeff
Copy link

@ydcjeff ydcjeff commented Mar 2, 2021

Enables docs navigation with left/right arrow keys. It can be useful for the ones who navigate with keyboard a lot.
More info : sphinx-doc/sphinx#2064

@zhangguanheng66
Copy link
Contributor

Can we have a preview of this change?

@zhangguanheng66
Copy link
Contributor

cc @brianjo

@ydcjeff
Copy link
Author

ydcjeff commented Mar 2, 2021

@zhangguanheng66 There is no artifacts uploaded in build_doc job as far as I found out.
But there is a preview from audio : https://174236-90321822-gh.circle-artifacts.com/0/docs/index.html

@zhangguanheng66
Copy link
Contributor

I was wondering if we could avoid to collapse the navigation for "Package Reference".

@ydcjeff
Copy link
Author

ydcjeff commented Mar 2, 2021

I was wondering if we could avoid to collapse the navigation for "Package Reference".

That was caused by pytorch_sphinx_theme, I have sent a PR here pytorch/pytorch_sphinx_theme#97

@zhangguanheng66
Copy link
Contributor

I was wondering if we could avoid to collapse the navigation for "Package Reference".

That was caused by pytorch_sphinx_theme, I have sent a PR here pytorch/pytorch_sphinx_theme#97

Thanks for the quick response. I will merge it once @brianjo approves it.

@zhangguanheng66
Copy link
Contributor

I also have a request. Different from vision and audio, the font of text is bold everywhere. Can we fix this for consistency?

@ydcjeff
Copy link
Author

ydcjeff commented Mar 2, 2021

I also have a request. Different from vision and audio, the font of text is bold everywhere. Can we fix this for consistency?

I think that maybe cause of fonts torchtext using (Lato which has thick line width) while vision and audio is FreightSans which has thin line width. Both of 3 sites are using same font weight.

@zhangguanheng66
Copy link
Contributor

I also have a request. Different from vision and audio, the font of text is bold everywhere. Can we fix this for consistency?

I think that maybe cause of fonts torchtext using (Lato which has thick line width) while vision and audio is FreightSans which has thin line width. Both of 3 sites are using same font weight

Can we fix this? Or point me where to fix this. Thanks a lot.

@ydcjeff
Copy link
Author

ydcjeff commented Mar 2, 2021

Sure you need to remove this line and font-family in this file

@zhangguanheng66
Copy link
Contributor

Sure you need to remove this line and font-family in this file

Not sure. It seems torchaudio also use Lato. See here.

@ydcjeff
Copy link
Author

ydcjeff commented Mar 2, 2021

@zhangguanheng66 Updated the previous comment.
torchaudio doesn't have Lato font in https://github.com/pytorch/audio/blob/master/docs/source/conf.py

@ydcjeff ydcjeff closed this May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants