Move aot_cudagraphs backend here #757
Merged
+343
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it was in pytorch/pytorch but it depends on torchdynamo code more closely, so this seems like the logical place. Previously at pytorch/pytorch#80566 Signed-off-by: Edward Z. Yang <ezyang@fb.com>
jansel
approved these changes
Aug 9, 2022
Signed-off-by: Edward Z. Yang <ezyang@fb.com>
|
@ezyang Should we also add a |
|
We have aot nvfuser, but I'm not sure how the cudagraphs integration with nvfuser works. @Chillee might know more, he said he hacked in inductor's cuda graphs support to nvfuser. Note that cuda graphs is antipattern for dynamic shapes, and also there is quite a bit of logic needed to get it right (which I think is being duped between this backend and inductors' cudagraphs support) |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 10, 2022
These files are now in pytorch/torchdynamo#757 Pull Request resolved: #83128 Approved by: https://github.com/ezyang
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Aug 11, 2022
) Summary: These files are now in pytorch/torchdynamo#757 Pull Request resolved: #83128 Approved by: https://github.com/ezyang Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/0e8beb7d0d1c10e155d650dcf57a8468b3faa423 Reviewed By: seemethere Differential Revision: D38600199 Pulled By: msaroufim fbshipit-source-id: 04906e1907fc916a4b22158c277d5ca6cf49bfd7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it was in pytorch/pytorch but it depends on torchdynamo
code more closely, so this seems like the logical place.
Previously at pytorch/pytorch#80566
Signed-off-by: Edward Z. Yang ezyang@fb.com