Fix all flake8 issues #4535
Merged
Fix all flake8 issues #4535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
approved these changes
Oct 4, 2021
|
The |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
Reviewed By: kazhang Differential Revision: D31387948 fbshipit-source-id: a2fb59c15a79dcf32654826e3b620a5e93584447
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes all outstanding flake8 issues that popped up after #4384 (#4384 (comment))
Most of it is just removing unused imports. I stayed conservative (i.e. keep the import with a
# noqa) when I wasn't sure.It also ignores the
line-too-longerrors from flake8: those are taken care of by black now anyway, but there can be minor conflicts in the case e.g. of https://github.com/pytorch/vision/blob/main/torchvision/models/detection/ssdlite.py#L21:L21, so we just keepflake8quite and trustblackin those cases.