Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of bounding_box for area freezing when available #623

Merged
merged 5 commits into from
Oct 1, 2024

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Oct 1, 2024

This PR adds the possibility to use the bounding box attribute of the swathdefinition to freeze a dynamic area definition.

  • Tests added
  • Tests passed
  • Fully documented

@mraspaud mraspaud self-assigned this Oct 1, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.97%. Comparing base (8cc6ec8) to head (c4ce8ee).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #623      +/-   ##
==========================================
- Coverage   93.98%   93.97%   -0.02%     
==========================================
  Files          86       86              
  Lines       13839    13848       +9     
==========================================
+ Hits        13006    13013       +7     
- Misses        833      835       +2     
Flag Coverage Δ
unittests 93.97% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 93.672% (-0.01%) from 93.682%
when pulling c4ce8ee on mraspaud:feature-bounding-box-2
into b279d35 on pytroll:main.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to document some of the special xarray .attrs that affect pyresample behavior, but I understand if you don't want it to be in this PR. This type of check could be moved to geoxarray in the future too.

@mraspaud mraspaud merged commit 9becb0d into pytroll:main Oct 1, 2024
23 of 26 checks passed
@mraspaud mraspaud deleted the feature-bounding-box-2 branch October 1, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants