-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use factory function for publisher creation in trollstalker and switch to Watchdog #152
Conversation
Pull Request Test Coverage Report for Build 7871571797Details
💛 - Coveralls |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 90.76% 91.23% +0.46%
==========================================
Files 32 32
Lines 4420 4416 -4
==========================================
+ Hits 4012 4029 +17
+ Misses 408 387 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The blacklisting of watchdog 4.0.0 is because of a bug solved in: gorakhargosh/watchdog#1032 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR uses factory function for publisher creation in trollstalker and switches it to Watchdog