Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use factory function for publisher creation in trollstalker and switch to Watchdog #152

Merged
merged 5 commits into from
Feb 12, 2024

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Feb 8, 2024

This PR uses factory function for publisher creation in trollstalker and switches it to Watchdog

@mraspaud mraspaud self-assigned this Feb 8, 2024
@coveralls
Copy link

coveralls commented Feb 8, 2024

Pull Request Test Coverage Report for Build 7871571797

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Totals Coverage Status
Change from base Build 7828186224: 0.0%
Covered Lines: 0
Relevant Lines: 0

💛 - Coveralls

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (7965e59) 90.76% compared to head (ed449f1) 91.23%.
Report is 2 commits behind head on main.

❗ Current head ed449f1 differs from pull request most recent head 87045bc. Consider uploading reports for the commit 87045bc to get more accurate results

Files Patch % Lines
pytroll_collectors/trollstalker.py 77.43% 37 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #152      +/-   ##
==========================================
+ Coverage   90.76%   91.23%   +0.46%     
==========================================
  Files          32       32              
  Lines        4420     4416       -4     
==========================================
+ Hits         4012     4029      +17     
+ Misses        408      387      -21     
Flag Coverage Δ
unittests 91.23% <82.21%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mraspaud
Copy link
Member Author

The blacklisting of watchdog 4.0.0 is because of a bug solved in: gorakhargosh/watchdog#1032

@mraspaud mraspaud marked this pull request as ready for review February 12, 2024 13:36
@mraspaud mraspaud requested a review from pnuu February 12, 2024 13:36
Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 9a998c3 into pytroll:main Feb 12, 2024
6 checks passed
@mraspaud mraspaud deleted the update-trollstalker branch February 12, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants