Fix nasa ftp retrieval #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring my fork up to date
…nnection) Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
|
Well, my simple change from "FTP" to "FTP_TLS" was too simple, I will be back.... |
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
|
Ok, now I think we are ok |
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
|
Sorry, wait, I think there is something I can improve... |
Signed-off-by: Adam Dybbroe <Adam.Dybbroe@smhi.se>
|
Ok, ready. Can I merge @pnuu ? |
|
If it works, why not. I don't use this feature myself, so can't test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NASA has changed to no longer support plain FTP access for reasons of security. Only FTPS or HTTPS is now supported by these servers.
Now we use ftplib.FTP_TLS instead of ftplib.FTP to connect to the nasa server in order to download Aqua/Terra downlink schedules
This PR also fixes and improves a few other issues:
Get rid of Satpy dependency
Fix for latest Pyresample
Add stickler checks
Use six module to sole urlparse imports instead of try-except solution
Closes #xxxx
Tests added
Tests passed
Passes
git diff origin/master **/*py | flake8 --diffFully documented