Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safe loading for YAML config file #64

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Oct 20, 2021

Pyyaml 6.0 requires the loader to be defined for YAML reading. This PR switches from yaml.load() to yaml.safe_load() for reading the config file.

  • Tests passed
  • Passes git diff origin/main **/*py | flake8 --diff

@pnuu pnuu requested review from mraspaud and adybbroe October 20, 2021 10:16
@pnuu pnuu self-assigned this Oct 20, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #64 (47dc595) into main (ee08e0f) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   46.49%   46.49%           
=======================================
  Files          15       15           
  Lines        2540     2540           
=======================================
  Hits         1181     1181           
  Misses       1359     1359           
Impacted Files Coverage Δ
trollsched/utils.py 15.47% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee08e0f...47dc595. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 8d1fe8f into pytroll:main Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants