Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated usage of pyspectral's download_luts aerosol_type #2910

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Sep 25, 2024

Noticed while removing a usage in pyspectral. See pytroll/pyspectral#235

  • Closes #xxxx
  • Tests added
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@djhoese djhoese added the bug label Sep 25, 2024
@djhoese djhoese self-assigned this Sep 25, 2024
Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.06%. Comparing base (9e3b342) to head (7421103).
Report is 217 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2910   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         373      373           
  Lines       54465    54406   -59     
=======================================
- Hits        52321    52267   -54     
+ Misses       2144     2139    -5     
Flag Coverage Δ
behaviourtests 3.99% <ø> (+<0.01%) ⬆️
unittests 96.16% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11038889658

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.164%

Totals Coverage Status
Change from base Build 10957325874: 0.0%
Covered Lines: 52501
Relevant Lines: 54595

💛 - Coveralls

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 4169a21 into pytroll:main Oct 18, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants