Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spline interpolation for faster processing #2927

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

mraspaud
Copy link
Member

This PR makes use of the newer spline interpolation in python geotiepoints to improve the performance of the SAR and SGLI readers.

This requires pytroll/python-geotiepoints#85 to be merged and released.

  • Tests added

@mraspaud mraspaud added enhancement code enhancements, features, improvements component:readers labels Oct 11, 2024
@mraspaud mraspaud self-assigned this Oct 11, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.07%. Comparing base (7eb17ab) to head (12ebe3f).
Report is 48 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2927   +/-   ##
=======================================
  Coverage   96.07%   96.07%           
=======================================
  Files         373      373           
  Lines       54479    54491   +12     
=======================================
+ Hits        52338    52352   +14     
+ Misses       2141     2139    -2     
Flag Coverage Δ
behaviourtests 3.99% <0.00%> (-0.01%) ⬇️
unittests 96.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Oct 14, 2024

Pull Request Test Coverage Report for Build 11353495088

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 3 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 96.17%

Files with Coverage Reduction New Missed Lines %
satpy/composites/init.py 6 95.05%
Totals Coverage Status
Change from base Build 11304823079: 0.004%
Covered Lines: 52586
Relevant Lines: 54680

💛 - Coveralls

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment inline.

satpy/readers/sar_c_safe.py Outdated Show resolved Hide resolved
satpy/readers/sar_c_safe.py Outdated Show resolved Hide resolved
@mraspaud mraspaud merged commit a5f0e4d into pytroll:main Oct 17, 2024
18 checks passed
@mraspaud mraspaud deleted the switch-to-spline-interpolation branch October 17, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants