Replace patched print with capsys fixture
#2929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnuu
requested changes
Oct 12, 2024
Comment on lines
+284
to
+285
| assert checked_fake, "Did not find __fake package mentioned in checks" | ||
| assert checked_viirs_sdr, "Did not find viirs_sdr in readers mentioned in checks" |
There was a problem hiding this comment.
I don't think these do what are meant to do:
>>> foo = "bar"
>>> assert foo, "bar"
>>> assert foo, "foo"
>>> assert foo == "foo"
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AssertionError
Comment on lines
+284
to
+285
| assert checked_fake, "Did not find __fake package mentioned in checks" | ||
| assert checked_viirs_sdr, "Did not find viirs_sdr in readers mentioned in checks" |
There was a problem hiding this comment.
I think this is working as intended (though i'm following along what was there before).
I /tmp> cat dbg.py
assert True, "you wont see me"
assert False, "this is a helpful message"
I /tmp> python3 dbg.py
Traceback (most recent call last):
File "/tmp/dbg.py", line 2, in <module>
assert False, "this is a helpful message"
^^^^^
AssertionError: this is a helpful message
I /tmp> There was a problem hiding this comment.
Oh, right. I misunderstood the assertion as I've never seen that before 🙈
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2929 +/- ##
=======================================
Coverage 96.06% 96.07%
=======================================
Files 373 373
Lines 54477 54479 +2
=======================================
+ Hits 52336 52338 +2
Misses 2141 2141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 11303672980Details
💛 - Coveralls |
verduijn
commented
Oct 12, 2024
Comment on lines
+284
to
+285
| assert checked_fake, "Did not find __fake package mentioned in checks" | ||
| assert checked_viirs_sdr, "Did not find viirs_sdr in readers mentioned in checks" |
There was a problem hiding this comment.
I think this is working as intended (though i'm following along what was there before).
I /tmp> cat dbg.py
assert True, "you wont see me"
assert False, "this is a helpful message"
I /tmp> python3 dbg.py
Traceback (most recent call last):
File "/tmp/dbg.py", line 2, in <module>
assert False, "this is a helpful message"
^^^^^
AssertionError: this is a helpful message
I /tmp>
pnuu
approved these changes
Oct 12, 2024
Comment on lines
+284
to
+285
| assert checked_fake, "Did not find __fake package mentioned in checks" | ||
| assert checked_viirs_sdr, "Did not find viirs_sdr in readers mentioned in checks" |
There was a problem hiding this comment.
Oh, right. I misunderstood the assertion as I've never seen that before 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change to replace patched print with nicer capsys fixture. Figured I would replace it other tests, turns out there was only one location.