Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bogus no_op implementation #2939

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

mraspaud
Copy link
Member

This PR reverts most of #2933, and slightly improve the documentation.

Thanks to @ameraner and @gerritholl for making me realise I was wrong :)

  • Code removed
  • Fully documented

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.11%. Comparing base (5634073) to head (d62b5d2).
Report is 74 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2939      +/-   ##
==========================================
+ Coverage   96.08%   96.11%   +0.03%     
==========================================
  Files         375      377       +2     
  Lines       54615    55067     +452     
==========================================
+ Hits        52478    52929     +451     
- Misses       2137     2138       +1     
Flag Coverage Δ
behaviourtests 3.95% <ø> (-0.03%) ⬇️
unittests 96.21% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ameraner ameraner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's a good addition to have a pre-defined no-op enhancement in generic.yaml!

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11384945788

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 96.212%

Totals Coverage Status
Change from base Build 11381112172: -0.001%
Covered Lines: 53167
Relevant Lines: 55260

💛 - Coveralls

@mraspaud mraspaud merged commit d61e6e8 into pytroll:main Oct 17, 2024
18 checks passed
@mraspaud mraspaud deleted the no-op-take-2 branch October 17, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants