Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make palettize work on numpy 2.0. #176

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

gerritholl
Copy link
Contributor

@gerritholl gerritholl commented Aug 7, 2024

Make palettize work on numpy 2.0.

  • Closes palettize fails in numpy2 #175 (remove if there is no corresponding issue, which should only be the case for minor changes)
  • Tests added (for all bug fixes or enhancements)
  • Tests passed (for all non-documentation changes)
  • Passes git diff origin/master **/*py | flake8 --diff (remove if you did not edit any Python files)

Test that palettize works as expected on numpy 2.0.  Currently, it does
not — see GitHub pytroll#175.
Make sure palettize works on numpy2 by explicitly upcasting the bins
dtype.
@gerritholl gerritholl marked this pull request as ready for review August 7, 2024 07:33
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.54%. Comparing base (8b71319) to head (9139dee).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   91.53%   91.54%   +0.01%     
==========================================
  Files          11       11              
  Lines        4062     4068       +6     
==========================================
+ Hits         3718     3724       +6     
  Misses        344      344              
Flag Coverage Δ
unittests 91.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

Coverage Status

coverage: 91.79% (+0.01%) from 91.777%
when pulling 9139dee on gerritholl:bugfix-palettize-np2
into c665c4d on pytroll:main.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for spotting and fixing this.

@mraspaud mraspaud merged commit e7b0cdb into pytroll:main Aug 15, 2024
26 checks passed
@mraspaud mraspaud added the bug label Aug 15, 2024
@gerritholl gerritholl deleted the bugfix-palettize-np2 branch August 15, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

palettize fails in numpy2
3 participants